Re: testing cvs HEAD - HS/SR - missing file - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: testing cvs HEAD - HS/SR - missing file
Date
Msg-id 3f0b79eb1001270246s7313e00aw8ba42d680e12e348@mail.gmail.com
Whole thread Raw
In response to Re: testing cvs HEAD - HS/SR - missing file  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
Responses Re: testing cvs HEAD - HS/SR - missing file  (Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>)
List pgsql-hackers
On Wed, Jan 27, 2010 at 7:05 PM, Heikki Linnakangas
<heikki.linnakangas@enterprisedb.com> wrote:
> Before that, endptr is advanced using XLByteAdvance() macro, which does
> handle xlogid boundaries. Is XLByteAdvance() broken?

No. The cause of the bug is that endptr might be set to the SendRqstPtr
that has crossed a xlogid boundary in the following code.

>        /* if we went beyond SendRqstPtr, back off */
>        if (XLByteLT(SendRqstPtr, endptr))
>            endptr = SendRqstPtr;

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Tim Bunce
Date:
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]
Next
From: Martin Atukunda
Date:
Subject: Re: Patch: psql \whoami option