Re: [PATCH] Provide rowcount for utility SELECTs - Mailing list pgsql-hackers

From Boszormenyi Zoltan
Subject Re: [PATCH] Provide rowcount for utility SELECTs
Date
Msg-id 4B4C85D7.1060409@cybertec.at
Whole thread Raw
In response to Re: [PATCH] Provide rowcount for utility SELECTs  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Provide rowcount for utility SELECTs  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Tom Lane írta:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
>
>> But it would be broken in very obvious ways, no?  It's not like it would
>> be silently broken and thus escape testing ...
>>
>
> Well, if we wanted to adopt that approach, we should add the count to
> *all* SELECT tags not just a small subset.  As the patch stands it
> seems entirely possible that a breakage would escape immediate notice.
>
>             regards, tom lane
>

Can you give me an example that would return
plain "SELECT" after my new patch? I added
one more change to the patch, is it enough to return
"SELECT N" in every case now?

Best regards,
Zoltán Böszörményi

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/


Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: Streaming replication status
Next
From: Tom Lane
Date:
Subject: Re: NOT NULL violation and error-message