Re: Hot Standby remaining issues - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Hot Standby remaining issues
Date
Msg-id 4B1399A5.7080607@enterprisedb.com
Whole thread Raw
In response to Re: Hot Standby remaining issues  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Hot Standby remaining issues
List pgsql-hackers
Simon Riggs wrote:
> @@ -654,10 +656,13 @@ LockAcquire(const LOCKTAG *locktag,
>                  elog(PANIC, "lock table corrupted");
>          }
>          LWLockRelease(partitionLock);
> -        ereport(ERROR,
> -                (errcode(ERRCODE_OUT_OF_MEMORY),
> -                 errmsg("out of shared memory"),
> -          errhint("You might need to increase max_locks_per_transaction.")));
> +        if (reportLockTableError)
> +            ereport(ERROR,
> +                    (errcode(ERRCODE_OUT_OF_MEMORY),
> +                     errmsg("out of shared memory"),
> +              errhint("You might need to increase max_locks_per_transaction.")));
> +        else
> +            return LOCKACQUIRE_NOT_AVAIL;
>      }
>      locallock->proclock = proclock;
>  

That seems dangerous when dontWait==false.

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: draft RFC: concept for partial, wal-based replication
Next
From: Andrew Gierth
Date:
Subject: Re: Aggregate ORDER BY patch