Re: Aggregate ORDER BY patch - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Aggregate ORDER BY patch
Date
Msg-id 87pr70wc5c.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Aggregate ORDER BY patch  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: Aggregate ORDER BY patch
Re: Aggregate ORDER BY patch
Re: Aggregate ORDER BY patch
List pgsql-hackers
Updated version of the aggregate order by patch.

Includes docs + regression tests all in the same patch.

Changes:

  - removed SortGroupClause.implicit as per review comments,
    replacing it with separate lists for Aggref.aggorder and
    Aggref.aggdistinct.

  - Refactored in order to move the bulk of the new parse code
    out of ParseFuncOrColumn which was already quite big enough,
    into parse_agg.c

  - fixed a bug with incorrect deparse in ruleutils (and added a
    bunch of regression tests for deparsing and view usage)

  - added some comments

--
Andrew (irc:RhodiumToad)


Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Hot Standby remaining issues
Next
From: Robert Haas
Date:
Subject: Re: draft RFC: concept for partial, wal-based replication