Re: phypot - Pygmy Hippotause ? - Mailing list pgsql-hackers

From Kevin Grittner
Subject Re: phypot - Pygmy Hippotause ?
Date
Msg-id 4A97AB19020000250002A4EA@gw.wicourts.gov
Whole thread Raw
In response to phypot - Pygmy Hippotause ?  (Paul Matthews <plm@netspace.net.au>)
Responses Re: phypot - Pygmy Hippotause ?  (Paul Matthews <plm@netspace.net.au>)
List pgsql-hackers
Paul Matthews <plm@netspace.net.au> wrote: 
> Feedback appreciated.
+     /* As x is the larger value, this must be the correct answer.
Also
+      * avoids division by zero. */
+     if( x == 0.0 )
+         return 0.0;
+ 
+     /* Trivial case. */
+     if( y == 0.0 )
+         return x;
The first test seems unnecessary if you have the second.
x >= 0, so x can't be zero unless y is, too.
Returning x on y == 0.0 will return 0.0 whenever x == 0.0.
-Kevin


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCH] Largeobject access controls
Next
From: Marko Tiikkaja
Date:
Subject: UPDATE .. RETURNING OLD.*