Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the - Mailing list pgsql-hackers

From Markus Wanner
Subject Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the
Date
Msg-id 4884A34E.4050002@bluegap.ch
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

Tom Lane wrote:
> This seems like a bad idea, because it makes the code gratuitously
> different from the names used for this purpose everywhere else.

I find that a pretty dubious reason for having 'query_string' and 
'queryString' in the same function. In fact, having it in the same code 
base seems strange. It makes me wish we had (better!) naming 
conventions...  Something I've stumbled over often enough during my work 
with Postgres - What was it again: 'query_string' (87 times), 
'queryString' (77 times) or 'querystr' (42 times)?

However, what about at least adding a comment, so fellow hackers have a 
chance of understanding the subtle difference there?

Regards

Markus



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: overlaps performance
Next
From: Tom Lane
Date:
Subject: Re: Default of max_stack_depth and getrlimit