Re: Use XLOG_CONTROL_FILE macro everywhere? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Use XLOG_CONTROL_FILE macro everywhere?
Date
Msg-id 474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org
Whole thread Raw
In response to Use XLOG_CONTROL_FILE macro everywhere?  ("Anton A. Melnikov" <a.melnikov@postgrespro.ru>)
Responses Re: Use XLOG_CONTROL_FILE macro everywhere?
List pgsql-hackers
On 19.04.24 05:50, Anton A. Melnikov wrote:
> There is a macro XLOG_CONTROL_FILE for control file name
> defined in access/xlog_internal.h
> And there are some places in code where this macro is used
> like here
>
https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/bin/pg_resetwal/pg_resetwal.c#L588
> or here
>
https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/common/controldata_utils.c#L214
> 
> But there are some other places where the control file
> name is used as text string directly.
> 
> May be better use this macro everywhere in C code?

I don't know.  I don't find XLOG_CONTROL_FILE to be a very intuitive 
proxy for "pg_control".




pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: WIP Incremental JSON Parser
Next
From: "Anton A. Melnikov"
Date:
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?