Use XLOG_CONTROL_FILE macro everywhere? - Mailing list pgsql-hackers

From Anton A. Melnikov
Subject Use XLOG_CONTROL_FILE macro everywhere?
Date
Msg-id 0841ec77-47e5-452a-adb4-c6fa55d605fc@postgrespro.ru
Whole thread Raw
Responses Re: Use XLOG_CONTROL_FILE macro everywhere?
Re: Use XLOG_CONTROL_FILE macro everywhere?
List pgsql-hackers
Hello!

There is a macro XLOG_CONTROL_FILE for control file name
defined in access/xlog_internal.h
And there are some places in code where this macro is used
like here

https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/bin/pg_resetwal/pg_resetwal.c#L588
or here
https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/common/controldata_utils.c#L214

But there are some other places where the control file
name is used as text string directly.

May be better use this macro everywhere in C code?
The patch attached tries to do this.

Would be glad if take a look on it.

With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment

pgsql-hackers by date:

Previous
From: Colin Caine
Date:
Subject: Okay to remove mention of mystery @ and ~ operators?
Next
From: Thomas Munro
Date:
Subject: Re: Allow tests to pass in OpenSSL FIPS mode