Re: Feature Request: inline comments - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Feature Request: inline comments
Date
Msg-id 47324F47.6060809@dunslane.net
Whole thread Raw
In response to Re: Feature Request: inline comments  (CaT <cat@zip.com.au>)
List pgsql-hackers

CaT wrote:
> On Wed, Nov 07, 2007 at 06:32:53PM -0500, Tom Lane wrote:
>   
>> CaT <cat@zip.com.au> writes:
>>     
>>> It is a pretty obvious suggestion I bet was made many, many times
>>> before, but it would be very useful if you could create comments while
>>> creating the objects themselves, like
>>>       
>>> CREATE TABLE FOO (
>>>    ID INTEGER NOT NULL PRIMARY KEY COMMENT 'The ID',
>>>    VALUE VARCHAR(10) COMMENT 'The value',
>>> ) COMMENT 'The table';
>>>       
>> This seems like a fairly bad idea to me, because it converts your table
>> definitions into proprietary syntax.  Heaven help you trying to load the
>> above into any other database.  With a separate COMMENT ON command, at
>> least you have a fighting chance of ignoring the errors and pressing on.
>>     
>
> Well, in a dump of the DB, you could have them as COMMENT ON. Otherwise
> I /think/ this should do it in vim at least:
>
> :%s/ COMMENT '\([^']*''\)*[^']*'//
>
> It's not a perfect regex (though I think it could be made to hand E''
> escaping) but it'll do for most comments.
>
>   

No it won't. There's dollar quoting to think of, and multiline comments. 
It all looks like clutter to me anyway.

cheers

andrew


pgsql-hackers by date:

Previous
From: CaT
Date:
Subject: Re: Feature Request: inline comments
Next
From: "Gevik Babakhani"
Date:
Subject: Re: Throw error and ErrorContext question.