Re: Crash with empty dictionary - Mailing list pgsql-hackers

From Hamid Quddus Akhtar
Subject Re: Crash with empty dictionary
Date
Msg-id 46CC3850.3090202@enterprisedb.com
Whole thread Raw
In response to Re: Crash with empty dictionary  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Crash with empty dictionary  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote: <blockquote cite="mid2336.1187760320@sss.pgh.pa.us" type="cite"><pre wrap="">Heikki Linnakangas <a
class="moz-txt-link-rfc2396E"href="mailto:heikki@enterprisedb.com"><heikki@enterprisedb.com></a> writes:
</pre><blockquotetype="cite"><pre wrap="">I'm not sure if this is a sane way to set up a dictionary, but surely
 
seg faulting is not the right thing to do. Should we throw an error on
an empty dict file, or should we swallow it without crashing?   </pre></blockquote><pre wrap="">
Offhand I'd say that an empty file is a legitimate corner case,
so we should just take it silently.
        regards, tom lane

---------------------------(end of broadcast)---------------------------
TIP 7: You can help support the PostgreSQL project by donating at
               <a class="moz-txt-link-freetext"
href="http://www.postgresql.org/about/donate">http://www.postgresql.org/about/donate</a>

 </pre></blockquote><br /> Shouldn't we be warning about an empty file rather than just swallowing up the error? It
mightnot be intentional and rather than the user trying to figure it out, we should at least be informing him/her...<br
/><br/> --<br /> Hamid<br /> 

pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: tsearch2 patch status report
Next
From: Tom Lane
Date:
Subject: Re: A couple of tsearch loose ends