Re: Crash with empty dictionary - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Crash with empty dictionary
Date
Msg-id 7201.1187792307@sss.pgh.pa.us
Whole thread Raw
In response to Re: Crash with empty dictionary  ("Hamid Quddus Akhtar" <hamid.akhtar@enterprisedb.com>)
Responses Re: Crash with empty dictionary  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
"Hamid Quddus Akhtar" <hamid.akhtar@enterprisedb.com> writes:
>> Offhand I'd say that an empty file is a legitimate corner case,
>> so we should just take it silently.

> Shouldn't we be warning about an empty file rather than just swallowing 
> up the error?

You are jumping to a conclusion, namely that it is an error.  If it's
a legitimate corner case, throwing a warning every time the file is
read would be incredibly annoying.

If it's not a legitimate case, then we should throw a real error.
A warning just strikes me as the worst of both worlds.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: A couple of tsearch loose ends
Next
From: Bruce Momjian
Date:
Subject: Re: Crash with empty dictionary