Re: Crash with empty dictionary - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Crash with empty dictionary
Date
Msg-id 200708221424.l7MEOfY03219@momjian.us
Whole thread Raw
In response to Re: Crash with empty dictionary  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Crash with empty dictionary  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-hackers
Tom Lane wrote:
> "Hamid Quddus Akhtar" <hamid.akhtar@enterprisedb.com> writes:
> >> Offhand I'd say that an empty file is a legitimate corner case,
> >> so we should just take it silently.
> 
> > Shouldn't we be warning about an empty file rather than just swallowing 
> > up the error?
> 
> You are jumping to a conclusion, namely that it is an error.  If it's
> a legitimate corner case, throwing a warning every time the file is
> read would be incredibly annoying.
> 
> If it's not a legitimate case, then we should throw a real error.
> A warning just strikes me as the worst of both worlds.

A zero-length file seems fine to me in this case.

--  Bruce Momjian  <bruce@momjian.us>          http://momjian.us EnterpriseDB
http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Crash with empty dictionary
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: A couple of tsearch loose ends