Re: INSERT..SELECT with GENERATE_SERIES returns error. - Mailing list pgsql-hackers

Debugged a bit and problem seem to be in ExecMakeFunctionResult().

We prepare a resultinfo node only If function returns set; so "returnMode" will get set only when function returns is set.

   if (fcache->func.fn_retset)
   {
      .....
       /* note we do not set SFRM_Materialize_Random or _Preferred */
       rsinfo.returnMode = SFRM_ValuePerCall;
      ....
   }

After calling the function we are looking for the "rsinfo.returnMode" which is not set in this case. And we endup with error.
Seems like we missing the check for "hasSetArg".

I added the following condition and query worked fine (Not sure how correct it is).
Inputs ??


diff --git a/src/backend/executor/execQual.c b/src/backend/executor/execQual.c
index 8df00ed..a23e35e 100644
--- a/src/backend/executor/execQual.c
+++ b/src/backend/executor/execQual.c
@@ -1513,7 +1513,8 @@ restart:
                        }
 
                        /* Which protocol does function want to use? */
-                       if (rsinfo.returnMode == SFRM_ValuePerCall)
+                       if (rsinfo.returnMode == SFRM_ValuePerCall ||
+                                       (!fcache->func.fn_retset && hasSetArg))
                        {
                                if (*isDone != ExprEndResult)
                                {