While working with postgres code, I found that for gist index number of
amsupport procs are defined two times. First in src/include/access/gist.h
#define GISTNProcs 9
and second in src/backend/access/gist/gist.c
amroutine->amsupport = 9;
I think this number should be specified only once, in .h file.
So I would offer a patch for all access methods. That changes amsupport and
amstrategies from numbers to defined constants. (I've added two of them where
they were missing)
See attachment.
If it is good, I will add it to the commitfest.
--
Nikolay Shaplov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
