Re: scripts/common.c minor memory leak - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: scripts/common.c minor memory leak
Date
Msg-id 4522D5C3.7000103@dunslane.net
Whole thread Raw
In response to scripts/common.c minor memory leak  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: scripts/common.c minor memory leak  (Martijn van Oosterhout <kleptog@svana.org>)
List pgsql-hackers
Martijn van Oosterhout wrote:
> Just a minor thing. In yesno_prompt(), the value is resp is allocated
> memory that is never freed.
>
> File: src/bin/scripts/common.c
> Line: 218
>
> Not terribly important though, it's not used in critical utilities, but
> it's used often.
>
> Found by coverity.
>   

It is surely not the only memory leak.  We know there are some and in 
most cases (like this) they aren't worth the trouble to clean up. If it 
were used in psql or the backend I'd be worried, but it isn't, so I'm not.

cheers

andrew


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Numeric overflow problem + patch
Next
From: "Jim C. Nasby"
Date:
Subject: timetz storage vs timestamptz