Re: Curious bug in buildfarm files-changed links - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Curious bug in buildfarm files-changed links
Date
Msg-id 44935FF6.9050805@dunslane.net
Whole thread Raw
In response to Curious bug in buildfarm files-changed links  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Curious bug in buildfarm files-changed links  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:

>Observe the list of "Files changed this run" at
>http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gazelle&dt=2006-06-17%2000:30:01
>
>The links to the core-system files are OK but the plpgsql files are not
>correct, eg
>    pgsql/src/gram.y 1.93
>where it should be
>    pgsql/src/pl/plpgsql/src/gram.y 1.93
>
>I'm betting on an overly-greedy regex ...
>  
>

Good catch.

As usual you are spot on.

The offending line is this one, which is parsing CVS status output (if 
you don't read perl just close your eyes):
      s!.*Repository revision:.(\d+(\.\d+)+).*(pgsql/.*),v.*!$3 $1!;

I think the simplest fix would be just to require a / before the 
filename capture:
     s!.*Repository revision:.(\d+(\.\d+)+).*/(pgsql/.*),v.*!$3 $1!;


cheers

andrew


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Curious bug in buildfarm files-changed links
Next
From: Tatsuo Ishii
Date:
Subject: Re: [PERFORM] Sun Donated a Sun Fire T2000 to the PostgreSQL