Re: [PATCHES] snprintf() argument reordering not working - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCHES] snprintf() argument reordering not working
Date
Msg-id 43951259.7010803@dunslane.net
Whole thread Raw
In response to Re: [PATCHES] snprintf() argument reordering not working  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] snprintf() argument reordering not working  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers

Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>>OK, eyeball this for the REL8_1_STABLE branch, please. It seems to 
>>>work for me. No exports necessary.
>>>      
>>>
>
>  
>
>>er try this instead. I missed a line from configure.in
>>    
>>
>
>I cleaned this up slightly and committed it into HEAD and 8.1 branches.
>It appears to work in that I can force pgac_need_repl_snprintf to "yes"
>on a Linux machine and get a working build.  But we need to verify that
>things are OK on Windows, both with the old libintl that the installer
>is using and with current libintl.  Please build and test ...
>  
>

the cleanup seems to have omitted the change I had to 
src/interfaces/ecpg/pgtypeslib/extern.h, which causes a build failure - see

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=loris&dt=2005-12-06%2003:30:36

If we don't do this then we need to link snprintf into libpgtypes just 
like we do for ecpg, but it seems like overkill.

cheers

andrew




pgsql-hackers by date:

Previous
From: Christopher Kings-Lynne
Date:
Subject: Bug in pg_dump -c with casts
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] snprintf() argument reordering not working