Re: XADataSource implementation - Mailing list pgsql-jdbc

From Oliver Jowett
Subject Re: XADataSource implementation
Date
Msg-id 4324E15B.5040207@opencloud.com
Whole thread Raw
In response to XADataSource implementation  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: XADataSource implementation  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-jdbc
Heikki Linnakangas wrote:
> I've been working on the XADataSource implementation. Patch attached.
> Test case is in the separate zip file, because I couldn't get cvs to
> include it in the diff.

This looks good to me. A few comments:

- we'll need to wrap translatable strings in GT.tr() calls
- there are some places where you compare Xids by identity (==) --
shouldn't these be using .equals()?
- do we really need all of that Base64 encoder/decoder class? Seems like
we could get away with something much more simple.

-O

pgsql-jdbc by date:

Previous
From: Oliver Jowett
Date:
Subject: Re: TimestampUtils.loadCalendar failes for interval type
Next
From: Angelo Neuschitzer
Date:
Subject: Strange behavoir of batches