Re: [HACKERS] For review: Server instrumentation patch - Mailing list pgsql-patches

From Andreas Pflug
Subject Re: [HACKERS] For review: Server instrumentation patch
Date
Msg-id 42FC87D6.6040107@pse-consulting.de
Whole thread Raw
In response to Re: [HACKERS] For review: Server instrumentation patch  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [HACKERS] For review: Server instrumentation patch  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-patches
Bruce Momjian wrote:

>
> I did not include pg_logdir_ls because that was basically pg_ls_dir with
> logic to decode the log file name and convert it to a timestamp.  That
> seemed best done in the client.

IMHO omitting pg_logdir_ls is a bad idea, because the function is
intended to hide server internal's naming scheme from the user. We want
as few server side implementation specific client side code as possible.
    In addition, pg_logdir_ls filters files that are not log files.
You'll probably have trouble writing a query that performes this task.

Regards,
Andreas

pgsql-patches by date:

Previous
From: "Dave Page"
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch