Andrew Dunstan wrote:
>
> I didn't see the original of the later patch, which is why I sent in
> mine. I honestly don't care that much either way, although I'm inclined
> to agree that the header file is just unnecessary noise.
>
Well, looks like a strong feeling for no header :-). I didn't really
think about *not* having one to be honest. So, anyway - instead of
inviting Neil to spend valuable time eliminating it, I should do it
myself...
So, please ignore my previous patch to the header file, and consider
this one - which eliminates it completely.
best wishes
Mark
diff -Nacr pg_buffercache.orig/pg_buffercache_pages.c pg_buffercache/pg_buffercache_pages.c
*** pg_buffercache.orig/pg_buffercache_pages.c Fri Apr 1 11:25:49 2005
--- pg_buffercache/pg_buffercache_pages.c Fri Apr 1 11:28:22 2005
***************
*** 12,18 ****
#include "storage/buf_internals.h"
#include "storage/bufmgr.h"
#include "utils/relcache.h"
- #include "pg_buffercache_pages.h"
#define NUM_BUFFERCACHE_PAGES_ELEM 6
--- 12,17 ----
***************
*** 21,26 ****
--- 20,27 ----
extern DLLIMPORT BufferDesc *BufferDescriptors;
extern DLLIMPORT volatile uint32 InterruptHoldoffCount;
#endif
+
+ Datum pg_buffercache_pages(PG_FUNCTION_ARGS);
/*
diff -Nacr pg_buffercache.orig/pg_buffercache_pages.h pg_buffercache/pg_buffercache_pages.h
*** pg_buffercache.orig/pg_buffercache_pages.h Fri Apr 1 11:25:49 2005
--- pg_buffercache/pg_buffercache_pages.h Thu Jan 1 12:00:00 1970
***************
*** 1,18 ****
- /*-------------------------------------------------------------------------
- *
- * pg_buffercache_pages.h
- * Prototypes for pg_buffercache_pages
- *
- *
- * $PostgreSQL: pgsql/contrib/pg_buffercache/pg_buffercache_pages.h,v 1.1 2005/03/12 15:36:24 neilc Exp $
- *
- *-------------------------------------------------------------------------
- */
-
-
- #ifndef PG_BUFFERCACHE_PAGES_H
- #define PG_BUFFERCACHE_PAGES_H
-
- extern Datum pg_buffercache_pages(PG_FUNCTION_ARGS);
-
- #endif /* PG_BUFFERCACHE_PAGES_H */
--- 0 ----
