Re: [HACKERS] contrib/pg_buffercache - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: [HACKERS] contrib/pg_buffercache
Date
Msg-id 424BEDB0.6090706@dunslane.net
Whole thread Raw
In response to Re: [HACKERS] contrib/pg_buffercache  (Mark Kirkwood <markir@paradise.net.nz>)
Responses Re: [HACKERS] contrib/pg_buffercache
List pgsql-patches

Mark Kirkwood wrote:

> Neil Conway wrote:
>
>> Andrew Dunstan wrote:
>>
>>> I have confirmed that the attached patch works on Cygwin as well as
>>> Windows. Please apply.
>>
>>
>>
>> Applied, thanks.
>>
>
>
> Great that it fixes it... however, I had submitted a tidier patch that
> puts the macro in the header (probably after asking Andrew to test the
> first one, oops - sorry Andrew). I have tested it on win32 native.
>
> Do you want to back out the first one and use this instead?
>
>
>

I didn't see the original of the later patch, which is why I sent in
mine. I honestly don't care that much either way, although I'm inclined
to agree that the header file is just unnecessary noise.

cheers

andrew

pgsql-patches by date:

Previous
From: Mark Kirkwood
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache
Next
From: Mark Kirkwood
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache