Re: [HACKERS] contrib/pg_buffercache - Mailing list pgsql-patches

From Mark Kirkwood
Subject Re: [HACKERS] contrib/pg_buffercache
Date
Msg-id 424B820B.4030808@paradise.net.nz
Whole thread Raw
In response to Re: [HACKERS] contrib/pg_buffercache  (Neil Conway <neilc@samurai.com>)
Responses Re: [HACKERS] contrib/pg_buffercache  (Neil Conway <neilc@samurai.com>)
Re: [HACKERS] contrib/pg_buffercache  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Neil Conway wrote:
> Andrew Dunstan wrote:
>
>> I have confirmed that the attached patch works on Cygwin as well as
>> Windows. Please apply.
>
>
> Applied, thanks.
>

Great that it fixes it... however, I had submitted a tidier patch that
puts the macro in the header (probably after asking Andrew to test the
first one, oops - sorry Andrew). I have tested it on win32 native.

Do you want to back out the first one and use this instead?

regards

Mark

*** pg_buffercache_pages.h.orig    Thu Mar 17 10:12:20 2005
--- pg_buffercache_pages.h    Thu Mar 17 13:44:45 2005
***************
*** 15,18 ****
--- 15,24 ----

  extern Datum pg_buffercache_pages(PG_FUNCTION_ARGS);

+ /* A little hackery for Windows and Cygwin */
+ #if defined (WIN32) || defined (__CYGWIN__)
+ extern DLLIMPORT BufferDesc            *BufferDescriptors;
+ extern DLLIMPORT volatile uint32    InterruptHoldoffCount;
+ #endif
+
  #endif  /* PG_BUFFERCACHE_PAGES_H */


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Add URL of how to report bugs:
Next
From: Neil Conway
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache