Re: [HACKERS] contrib/pg_buffercache - Mailing list pgsql-patches

From Mark Kirkwood
Subject Re: [HACKERS] contrib/pg_buffercache
Date
Msg-id 424BB3FC.30907@paradise.net.nz
Whole thread Raw
In response to Re: [HACKERS] contrib/pg_buffercache  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
Neil Conway wrote:
> Mark Kirkwood wrote:
>
>> Great that it fixes it... however, I had submitted a tidier patch that
>> puts the macro in the header
>
>
> How is this tidier?
>

err... puts the macro in the header....

> (I don't see a reason for pg_buffercache_pages.h at all, actually.)
>
(chuckles) - well, that puts a different complexion on it, best leave it
as is then! (in fact, feel free to move the declaration from
pg_buffercache_pages.h to pg_buffercache_pages.c, and eliminate the
header altogether)

cheers

Mark

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache
Next
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] contrib/pg_buffercache