Re: pgsql: Test replay of regression tests, attempt II. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Test replay of regression tests, attempt II.
Date
Msg-id 415981.1642544346@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Test replay of regression tests, attempt II.  (Andres Freund <andres@anarazel.de>)
Responses Re: pgsql: Test replay of regression tests, attempt II.  (Thomas Munro <thomas.munro@gmail.com>)
Re: pgsql: Test replay of regression tests, attempt II.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> That's an extremely small shared_buffers for running the regression tests, it'd not
> be surprising if that provoked problems we don't otherwise see. Perhaps VACUUM
> ends up skipping over a page because of page contention?

Hmm, good thought.  I tried running the test with even smaller
shared_buffers, but could not make the reloptions test fall over for
me.  But this theory implies a strong timing dependency, so it might
still only happen on particular machines.  (If anyone else tries it:
below about 400kB, other tests start failing with "no free unpinned
buffers" and the like.)

> Also, it's odd that there's "max_connections 25" without an equal sign. I'd
> kind of expected that to cause an error....

I see that guc.c intentionally allows the equal sign to be optional.
Too lazy to check if that's documented.  It is weird that this one
test appears to be intentionally testing that, though, because it's
sure got nada to do with the expressed purpose of the test.

            regards, tom lane



pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Next
From: Thomas Munro
Date:
Subject: Re: pgsql: Test replay of regression tests, attempt II.