Re: [PATCH] Cleanup of GUC units code - Mailing list pgsql-hackers

From Greg Stark
Subject Re: [PATCH] Cleanup of GUC units code
Date
Msg-id 4136ffa0809080618v1d63a4f4m474c65ec8f999b0f@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Cleanup of GUC units code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Cleanup of GUC units code
Re: [PATCH] Cleanup of GUC units code
List pgsql-hackers
On Mon, Sep 8, 2008 at 2:11 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> But of course case insensitivity isn't going to fix that example for you.
> So we're right back at the question of where we should draw the line in
> trying to accept variant input.

Well it's not a perfect precedent but for example, dd accepts:

G    (2^30)
M    (2^20)
k     (2^10)
K    (2^10)
Kb  (10^3)
MB (10^6)
GB (10^9)
b    (512)

I think we're all agreed we want to ignore the KiB crap and make all
our units base 2. And I don't think usin "b" for block makes sense for
us. But the point is that yes, people expect to type "100M" or "1G"
and have that work. Plenty of us do it all the time with dd or other
tools already.

-- 
greg


pgsql-hackers by date:

Previous
From: Martin Pihlak
Date:
Subject: Re: reducing statistics write overhead
Next
From: Zdenek Kotala
Date:
Subject: Re: Prototype: In-place upgrade v02