Re: Is it really such a good thing for newNode() to be a macro? - Mailing list pgsql-hackers

From Greg Stark
Subject Re: Is it really such a good thing for newNode() to be a macro?
Date
Msg-id 4136ffa0808270845y74d9aeccv2be1bc0924c760ac@mail.gmail.com
Whole thread Raw
In response to Re: Is it really such a good thing for newNode() to be a macro?  ("Heikki Linnakangas" <heikki@enterprisedb.com>)
List pgsql-hackers
On Wed, Aug 27, 2008 at 4:05 PM, Heikki Linnakangas
<heikki@enterprisedb.com> wrote:
> Tom Lane wrote:
> BTW, it would be nice to have a test case that shows it's worth messing with
> that.

At a guess the parser would be a good place to look. Perhaps a
benchmark of a parsing a very large query?

One thing I wonder is if you (or someone else) gets around to doing
the simple stack allocator for the parser if it will make
microoptimizations like this more visible.

-- 
greg


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Is it really such a good thing for newNode() to be a macro?
Next
From: Michelle Caisse
Date:
Subject: code coverage patch