Re: Memory leak in vac_update_relstats ? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Memory leak in vac_update_relstats ?
Date
Msg-id 4093.1184939045@sss.pgh.pa.us
Whole thread Raw
In response to Re: Memory leak in vac_update_relstats ?  (NikhilS <nikkhils@gmail.com>)
List pgsql-hackers
NikhilS <nikkhils@gmail.com> writes:
> One specific case I want to mention here is hash_create(). For local hash
> tables if HASH_CONTEXT is not specified, they get created in a context which
> becomes a direct child of TopMemoryContext. Wouldn't it be a better idea to
> create the table in CurrentMemoryContext?

It works that way partly for historical reasons and mostly because the
vast majority of dynahash uses are for long-lived hash tables (a quick
search says that a default of CurrentMemoryContext would be correct for
only about one in ten of the current callers).  I don't see any value in
changing it.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "Pavan Deolasee"
Date:
Subject: MAXIMUM_ALIGNOF on Windows-32
Next
From: Tom Lane
Date:
Subject: Re: MAXIMUM_ALIGNOF on Windows-32