Re: Streaming replication on win32, still broken - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Streaming replication on win32, still broken
Date
Msg-id 3f0b79eb1002162307j7169fefdv5649420cc653335@mail.gmail.com
Whole thread Raw
In response to Re: Streaming replication on win32, still broken  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Streaming replication on win32, still broken
List pgsql-hackers
On Wed, Feb 17, 2010 at 3:03 PM, Magnus Hagander <magnus@hagander.net> wrote:
> In that case, O_DIRECT would be counterproductive, no? It maps to
> FILE_FLAG_NOI_BUFFERING, which makes sure it doesn't go into the
> cache. So the read in the startup proc is actually guaranteed to
> reuqire a physical read - of something we just wrote, so it'll almost
> certainly end up waiting for a rotation, no?
>
> Seems like getting rid of O_DIRECT here is the right thing to do,
> regardless of this.

Agreed. I'll remove O_DIRECT from walreceiver.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: CommitFest Status Summary - 2010-02-14
Next
From: Fujii Masao
Date:
Subject: Re: Streaming replication on win32, still broken