On Sun, 2024-04-14 at 15:33 -0700, Andres Freund wrote:
> - Coverage for some of the new unicode code is pretty poor:
>
> https://anarazel.de/postgres/cov/16-vs-HEAD-2024-04-14/src/common/unicode_category.c.gcov.html#L122
Thank you for looking. Those functions are tested by category_test.c
which is run with the 'update-unicode' target.
Better testing in the SQL tests might be good, but the existing tests
are near-exhaustive, so I'm not terribly worried. Also, it's possible
not all of them are reachable by SQL, yet, because some of the later
patches in the series didn't land in 17.
Regards,
Jeff Davis
