Re: [HACKERS] random_fract and aix compiler bug - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: [HACKERS] random_fract and aix compiler bug
Date
Msg-id 3F9029A2.20207@dunslane.net
Whole thread Raw
In response to Re: [HACKERS] random_fract and aix compiler bug  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:

>"Zeugswetter Andreas SB SD" <ZeugswetterA@spardat.at> writes:
>
>!     } while (!(z > 0 && z < MAX_RANDOM_VALUE));
>
>!     } while (z == 0 || z == MAX_RANDOM_VALUE);
>
>This seems fairly ugly, since it eliminates the original coding's
>positive guarantee that the final result is in 0 < x < 1.  Does your
>compiler manage not to choke if we add a cast instead?
>
>    } while (!(z > 0 && z < (long) MAX_RANDOM_VALUE));
>
>
>

Or put an "L" suffix on the value in pg_config_manual.h, so it gets
picked up everywhere?

cheers

andrew


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] random_fract and aix compiler bug
Next
From: Neil Conway
Date:
Subject: Re: introduce "default_use_oids"