Re: GUC patch for Win32 - Mailing list pgsql-patches

From Jan Wieck
Subject Re: GUC patch for Win32
Date
Msg-id 3EBA7A63.E8DC324@Yahoo.com
Whole thread Raw
In response to Re: GUC patch for Win32  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: GUC patch for Win32  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
>
> I said:
> > That way the file never changes after postmaster start and there can
> > be no race condition.  Children will instead have to read
> > postgresql.conf for themselves during their launch (after they read the
> > nondefault_variables file), but that's an easy one-line addition.
>
> On second thought, that just moves the race condition upstream (to the
> person editing postgresql.conf) ... so never mind that idea.  We don't
> want any part of Postgres reading postgresql.conf except shortly after
> someone has SIGHUP'd the postmaster.

I didn't actually look at that part of the code yet ... why would any
backend read postgresql.conf? I thought only the postmaster does that
and that he SIGHUP's all backends after writing the new file. That way
there is not race condition other that hupping the PM while w'ing the
file.


Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: GUC patch for Win32
Next
From: Tom Lane
Date:
Subject: Re: GUC patch for Win32