contrib/tablefunc bugfix - Mailing list pgsql-patches

From Joe Conway
Subject contrib/tablefunc bugfix
Date
Msg-id 3EB3DB11.7070909@joeconway.com
Whole thread Raw
Responses Re: contrib/tablefunc bugfix
Re: contrib/tablefunc bugfix
List pgsql-patches
A recent change in the backend exposed a missing include
(lib/stringinfo.h) in contrib/tablefunc. Attached is a fix. Please apply.

I checked and did not find any other contrib libraries affected.

I did find that contrib/cube fails `make installcheck` due to the bison
error message wording change (...syntax error... vs ... parse error
...). It seems contrib/seg was adjusted for this, but cube was not. Is
there a reason for that, or should I send in a patch?

Joe
Index: contrib/tablefunc/tablefunc.c
===================================================================
RCS file: /opt/src/cvs/pgsql-server/contrib/tablefunc/tablefunc.c,v
retrieving revision 1.15
diff -c -r1.15 tablefunc.c
*** contrib/tablefunc/tablefunc.c    27 Mar 2003 16:51:26 -0000    1.15
--- contrib/tablefunc/tablefunc.c    3 May 2003 14:38:00 -0000
***************
*** 31,38 ****

  #include "fmgr.h"
  #include "funcapi.h"
- #include "executor/spi.h"
  #include "miscadmin.h"
  #include "utils/builtins.h"
  #include "utils/guc.h"
  #include "utils/lsyscache.h"
--- 31,39 ----

  #include "fmgr.h"
  #include "funcapi.h"
  #include "miscadmin.h"
+ #include "executor/spi.h"
+ #include "lib/stringinfo.h"
  #include "utils/builtins.h"
  #include "utils/guc.h"
  #include "utils/lsyscache.h"

pgsql-patches by date:

Previous
From: Bradley Baetz
Date:
Subject: apply outer->inner join optimisation to OR clauses
Next
From: Tom Lane
Date:
Subject: Re: apply outer->inner join optimisation to OR clauses