contrib/dblink regression test failure fix - Mailing list pgsql-patches

From Joe Conway
Subject contrib/dblink regression test failure fix
Date
Msg-id 3D8F4645.3010906@joeconway.com
Whole thread Raw
Responses Re: contrib/dblink regression test failure fix  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Attached is a patch to fix the current regression test failure for
contrib/dblink. The failure was induced by recent changes to cast behavior. If
possible, please apply before creating the beta2 tarball.

Thanks,

Joe
Index: contrib/dblink/expected/dblink.out
===================================================================
RCS file: /opt/src/cvs/pgsql-server/contrib/dblink/expected/dblink.out,v
retrieving revision 1.2
diff -c -r1.2 dblink.out
*** contrib/dblink/expected/dblink.out    14 Sep 2002 22:00:59 -0000    1.2
--- contrib/dblink/expected/dblink.out    23 Sep 2002 16:39:40 -0000
***************
*** 56,62 ****

  -- build an insert statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_insert('foo','1 2',2,'{"0", "a"}','{"99", "xyz"}');
                    dblink_build_sql_insert
  -----------------------------------------------------------
   INSERT INTO foo(f1,f2,f3) VALUES('99','xyz','{a0,b0,c0}')
--- 56,62 ----

  -- build an insert statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_insert('foo','1 2',2::int2,'{"0", "a"}','{"99", "xyz"}');
                    dblink_build_sql_insert
  -----------------------------------------------------------
   INSERT INTO foo(f1,f2,f3) VALUES('99','xyz','{a0,b0,c0}')
***************
*** 64,77 ****

  -- build an update statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_update('foo','1 2',2,'{"0", "a"}','{"99", "xyz"}');
                                  dblink_build_sql_update
  ----------------------------------------------------------------------------------------
   UPDATE foo SET f1 = '99', f2 = 'xyz', f3 = '{a0,b0,c0}' WHERE f1 = '99' AND f2 = 'xyz'
  (1 row)

  -- build a delete statement based on a local tuple,
! select dblink_build_sql_delete('foo','1 2',2,'{"0", "a"}');
             dblink_build_sql_delete
  ---------------------------------------------
   DELETE FROM foo WHERE f1 = '0' AND f2 = 'a'
--- 64,77 ----

  -- build an update statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_update('foo','1 2',2::int2,'{"0", "a"}','{"99", "xyz"}');
                                  dblink_build_sql_update
  ----------------------------------------------------------------------------------------
   UPDATE foo SET f1 = '99', f2 = 'xyz', f3 = '{a0,b0,c0}' WHERE f1 = '99' AND f2 = 'xyz'
  (1 row)

  -- build a delete statement based on a local tuple,
! select dblink_build_sql_delete('foo','1 2',2::int2,'{"0", "a"}');
             dblink_build_sql_delete
  ---------------------------------------------
   DELETE FROM foo WHERE f1 = '0' AND f2 = 'a'
Index: contrib/dblink/sql/dblink.sql
===================================================================
RCS file: /opt/src/cvs/pgsql-server/contrib/dblink/sql/dblink.sql,v
retrieving revision 1.2
diff -c -r1.2 dblink.sql
*** contrib/dblink/sql/dblink.sql    14 Sep 2002 22:00:59 -0000    1.2
--- contrib/dblink/sql/dblink.sql    23 Sep 2002 16:39:09 -0000
***************
*** 48,61 ****

  -- build an insert statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_insert('foo','1 2',2,'{"0", "a"}','{"99", "xyz"}');

  -- build an update statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_update('foo','1 2',2,'{"0", "a"}','{"99", "xyz"}');

  -- build a delete statement based on a local tuple,
! select dblink_build_sql_delete('foo','1 2',2,'{"0", "a"}');

  --
  -- Connect back to the regression database and define the functions.
--- 48,61 ----

  -- build an insert statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_insert('foo','1 2',2::int2,'{"0", "a"}','{"99", "xyz"}');

  -- build an update statement based on a local tuple,
  -- replacing the primary key values with new ones
! select dblink_build_sql_update('foo','1 2',2::int2,'{"0", "a"}','{"99", "xyz"}');

  -- build a delete statement based on a local tuple,
! select dblink_build_sql_delete('foo','1 2',2::int2,'{"0", "a"}');

  --
  -- Connect back to the regression database and define the functions.

pgsql-patches by date:

Previous
From: Stephan Szabo
Date:
Subject: Re: Implementation of LIMIT on DELETE and UPDATE statements
Next
From: Tom Lane
Date:
Subject: Re: contrib/dblink regression test failure fix