Re: Broken code in gram.y - Mailing list pgsql-hackers

From Fernando Nasser
Subject Re: Broken code in gram.y
Date
Msg-id 3C96F3D3.62818DCF@redhat.com
Whole thread Raw
In response to Broken code in gram.y  (Fernando Nasser <fnasser@redhat.com>)
Responses Re: Broken code in gram.y  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-hackers
Well,

Someone just dropped the DROP DATABASE statement rules right in the
middle of the CREATE DATABASE production rules!!!

Fernando



Fernando Nasser wrote:
> 
> The OWNER production rules added to DROP DATABASE:
> 
> DropdbStmt:     DROP DATABASE database_name
>                                 {
>                                         DropdbStmt *n =
> makeNode(DropdbStmt);
>                                         n->dbname = $3;
>                                         $$ = (Node *)n;
>                                 }
>                 | OWNER opt_equal name
>                                 {
>                                         $$ = lconsi(4, makeList1($3));
>                                 }
>                 | OWNER opt_equal DEFAULT
>                                 {
>                                         $$ = lconsi(4, makeList1(NULL));
>                                 }
>                 ;
> 
> Cause compiler warnings and are clearly returning the wrong type
> (a List, instead of a Node).
> 
> (...)/pgsql/src/backend/parser/gram.y: In function
> `yyparse':/home/fnasser/DEVO/pgsql/pgsql/src/backend/parser/gram.y:3205:
> warning: assignment from incompatible pointer type
> (...)/pgsql/src/backend/parser/gram.y:3209: warning: assignment from
> incompatible pointer type
> 
> --
> Fernando Nasser
> Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
> 2323 Yonge Street, Suite #300
> Toronto, Ontario   M4P 2C9
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


pgsql-hackers by date:

Previous
From: Fernando Nasser
Date:
Subject: Broken code in gram.y
Next
From: "Christopher Kings-Lynne"
Date:
Subject: bug in domain support