Broken code in gram.y - Mailing list pgsql-hackers

From Fernando Nasser
Subject Broken code in gram.y
Date
Msg-id 3C96EDA3.5ED889B2@redhat.com
Whole thread Raw
List pgsql-hackers
The OWNER production rules added to DROP DATABASE:

DropdbStmt:     DROP DATABASE database_name                               {
DropdbStmt*n =
 
makeNode(DropdbStmt);                                       n->dbname = $3;                                       $$ =
(Node*)n;                               }               | OWNER opt_equal name                               {
                            $$ = lconsi(4, makeList1($3));                               }               | OWNER
opt_equalDEFAULT                               {                                       $$ = lconsi(4, makeList1(NULL));
                             }               ;
 


Cause compiler warnings and are clearly returning the wrong type
(a List, instead of a Node).

(...)/pgsql/src/backend/parser/gram.y: In function
`yyparse':/home/fnasser/DEVO/pgsql/pgsql/src/backend/parser/gram.y:3205:
warning: assignment from incompatible pointer type
(...)/pgsql/src/backend/parser/gram.y:3209: warning: assignment from
incompatible pointer type


-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


pgsql-hackers by date:

Previous
From: Thomas Lockhart
Date:
Subject: Re: Time zone questions
Next
From: Fernando Nasser
Date:
Subject: Re: Broken code in gram.y