Re: GiST on 64-bit box - Mailing list pgsql-hackers

From Teodor Sigaev
Subject Re: GiST on 64-bit box
Date
Msg-id 3C68298B.5060907@stack.net
Whole thread Raw
In response to GiST on 64-bit box  (Teodor Sigaev <teodor@stack.net>)
List pgsql-hackers
We got the report about this patch on 64-bit Solaris: it's work.

Teodor Sigaev wrote:
> This patch solve the problem with unaligned access on 64-bit box. Please 
> apply it for 7.2.1.
> 
> Tested on DEC Alpha.
> 
> Tom Lane wrote:
> 
>> Actually, there is a third possibility, which would fix the problem
>> without requiring any changes in the picksplit functions.  You could
>> do this:
>>
>>     char *storage;
>>
>>     storage = palloc(MAXALIGN(VARHDRSZ) + (*len + 1) * 
>> sizeof(GISTENTRY));
>>     entryvec = (bytea *) (storage + MAXALIGN(VARHDRSZ) - VARHDRSZ);
>>
>>     use entryvec as before, except final pfree is pfree(storage)
>>
>> Grotty as heck, but probably the right answer for 7.2.1 to avoid the
>> initdb issues.
>>
>> For 7.3 we could do it the other, cleaner way.
>>
>>             regards, tom lane
>>
>>
> 
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
> 


-- 
Teodor Sigaev
teodor@stack.net



pgsql-hackers by date:

Previous
From: Jan Wieck
Date:
Subject: Re: [GENERAL] Feature enhancement request : use of libgda
Next
From: Tom Lane
Date:
Subject: Re: [GENERAL] Feature enhancement request : use of libgda