Re: Minor pg_amcheck fixes spotted while reading code - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: Minor pg_amcheck fixes spotted while reading code
Date
Msg-id 3A6DD139-43F8-455D-BEE7-4D1CD0C013D3@enterprisedb.com
Whole thread Raw
In response to Minor pg_amcheck fixes spotted while reading code  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Minor pg_amcheck fixes spotted while reading code  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers

> On Aug 20, 2021, at 11:19 AM, Daniel Gustafsson <daniel@yesql.se> wrote:
>
> When perusing the pg_amcheck code the other day for the recently pushed fixes I
> found two small things that seem worth fixing: The help function progname
> parameter shadows the global variable of the same name, which no doubt will
> make static analyzers complain so we might as well fix that; and there is a
> tiny typo in the test stanza.
>
> Both fixed in the attached.
>
> --
> Daniel Gustafsson        https://vmware.com/
>
> <0001-Fix-variable-shadowing.patch><0002-pg_amcheck-test-typofix.patch>

These look correct.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: archive status ".ready" files may be created too early
Next
From: Robert Haas
Date:
Subject: Re: Use extended statistics to estimate (Var op Var) clauses