Re: Cleaning up historical portability baggage - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Cleaning up historical portability baggage
Date
Msg-id 3920417.1659710931@sss.pgh.pa.us
Whole thread Raw
In response to Re: Cleaning up historical portability baggage  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Cleaning up historical portability baggage
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> Overall, I don't think it's a great idea to keep all of these
> HAVE_WHATEVER macros around if the configure tests are gone. It might
> be necessary in the short term to make sure we don't regress the
> readability of the code, but I think it would be better to come up
> with other techniques for keeping the code readable rather than
> relying on the names of these vestigial macros as documentation.

Hmm ... I agree with you that the end result could be nicer code,
but what's making it nicer is a pretty substantial amount of human
effort for each and every call site.  Is anybody stepping forward
to put in that amount of work?

My proposal is to leave the call sites alone until someone feels
like doing that sort of detail work.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Cleaning up historical portability baggage
Next
From: Robert Haas
Date:
Subject: Re: Cleaning up historical portability baggage