Re: Please test peer (socket ident) auth on *BSD - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Please test peer (socket ident) auth on *BSD
Date
Msg-id 3834.1307033042@sss.pgh.pa.us
Whole thread Raw
In response to Re: Please test peer (socket ident) auth on *BSD  (Marko Kreen <markokr@gmail.com>)
List pgsql-hackers
Marko Kreen <markokr@gmail.com> writes:
> On Thu, Jun 2, 2011 at 7:20 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>> Then maybe we need to use "#ifndef WIN32" in those places. That's what we do
>> for similar cases.

> No, that would be a bad idea - uglifies code for no good reason.

> The function is referenced undef IS_AF_UNIX() check, so it would
> not be run anyway.  Even if it would run somehow, there is only
> 2 lines to return ENOSYS.

Yeah, but not compiling thirty lines in fe-connect.c is worthwhile.

The auth_peer code in the backend is #ifdef HAVE_UNIX_SOCKETS, and
I see no reason why this chunk in libpq shouldn't be as well.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Marko Kreen
Date:
Subject: Re: Please test peer (socket ident) auth on *BSD
Next
From: Peter Eisentraut
Date:
Subject: \d missing tab completion for composite types