-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wed, Apr 16, 2008 at 2:17 AM, Joshua D. Drake wrote:
> On Tue, 15 Apr 2008 12:12:24 -0400
> Alvaro Herrera wrote:
>
> > Tom Lane wrote:
> >
> > > I tend to just fix this stuff while committing, rather than lecture
> > > the submitters about it, but it undoubtedly is a time sink.
> >
> > Lesson learned: a useful task for another reviewer to do is to grab
> > the patch, fix the style issues, and post the fixed version. That
> > way, the "higher level reviewer" does not have to waste time on a
> > task that, really, anybody can do.
>
> The idea that we "fix" stylistic issues on the fly is not sustainable.
> We should offer help and mentorship to new patch submitters in all
> areas (including stylistic) but they should do the work. It is the only
> way we will mold them to submit patches in the proper way.
>
I agree. As a submitter I would much rather get an email saying e.g.
"Hey, your patch is nice but the code style sticks out like a sore
thumb. Please adopt surrounding naming convention and fix your
indentation per the rules at [link]." than have it fixed silently on
its way to being committed.
With the former I learn something and get to improve my own work.
With the latter, my next patch is probably going to have the exact
same problem, which is in the long term just making extra work for the
reviewers.
Cheers,
BJ
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: http://getfiregpg.org
iD8DBQFIBZZ95YBsbHkuyV0RAjviAJ9pBG6I3DAySIx6ARp2cLnYe+bAdACg/VAR
Xgvpg4iyWsbNk4QKGI//diw=
=yDoO
-----END PGP SIGNATURE-----
