Missing break in RelationFindReplTupleSeq - Mailing list pgsql-hackers

From Konstantin Knizhnik
Subject Missing break in RelationFindReplTupleSeq
Date
Msg-id 379743f6-ae91-b866-f7a2-5624e6d2b0a4@postgrespro.ru
Whole thread Raw
Responses Re: Missing break in RelationFindReplTupleSeq  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Eventually we find out that logical replication in the current version 
of Postgres works significantly slower on table with replica identity 
full than old pglogical implementation.

The comment to RelationFindReplTupleSeq says:

     Note that this stops on the first matching tuple.

But actually this function continue traversal until end of the table 
even if tuple was found.
I wonder if break; should be added to the end of for loop.

-- 
Konstantin Knizhnik
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: standby apply lag on inactive servers
Next
From: Alvaro Herrera
Date:
Subject: Re: Missing break in RelationFindReplTupleSeq