Re: Missing break in RelationFindReplTupleSeq - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Missing break in RelationFindReplTupleSeq
Date
Msg-id 20200131135831.GA1550@alvherre.pgsql
Whole thread Raw
In response to Missing break in RelationFindReplTupleSeq  (Konstantin Knizhnik <k.knizhnik@postgrespro.ru>)
Responses Re: Missing break in RelationFindReplTupleSeq
List pgsql-hackers
On 2020-Jan-31, Konstantin Knizhnik wrote:

> Eventually we find out that logical replication in the current version of
> Postgres works significantly slower on table with replica identity full than
> old pglogical implementation.
> 
> The comment to RelationFindReplTupleSeq says:
> 
>     Note that this stops on the first matching tuple.
> 
> But actually this function continue traversal until end of the table even if
> tuple was found.
> I wonder if break; should be added to the end of for loop.

Wow, you're right, and the "break" is missing there.  I propose it like
this.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Missing break in RelationFindReplTupleSeq
Next
From: Hamid Akhtar
Date:
Subject: Re: Do we need to handle orphaned prepared transactions in the server?