Re: [PATCH] Cleanup of PLpgSQL_recfield - Mailing list pgsql-hackers

From Jonah H. Harris
Subject Re: [PATCH] Cleanup of PLpgSQL_recfield
Date
Msg-id 36e682920811041517lf3482cbmc06765a4877a1262@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Cleanup of PLpgSQL_recfield  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] Cleanup of PLpgSQL_recfield  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Nov 4, 2008 at 3:57 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I am not real sure why the code is inconsistent about spelling the
> second field's name differently in some of the structs, but it seems
> like a bad idea --- as you've demonstrated, it invites confusion.
> What would probably be better is a patch to rename exprno, rfno, etc
> to all be called dno to make this connection more obvious.

Attached.  Passed regressions and basic testing.

--
Jonah H. Harris, Senior DBA
myYearbook.com

Attachment

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Updates of SE-PostgreSQL 8.4devel patches (r1168)
Next
From: Emmanuel Cecchet
Date:
Subject: Re: Transactions and temp tables