Re: [PATCH] Cleanup of PLpgSQL_recfield - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] Cleanup of PLpgSQL_recfield
Date
Msg-id 1050.1225843708@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] Cleanup of PLpgSQL_recfield  ("Jonah H. Harris" <jonah.harris@gmail.com>)
List pgsql-hackers
"Jonah H. Harris" <jonah.harris@gmail.com> writes:
> On Tue, Nov 4, 2008 at 3:57 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I am not real sure why the code is inconsistent about spelling the
>> second field's name differently in some of the structs, but it seems
>> like a bad idea --- as you've demonstrated, it invites confusion.
>> What would probably be better is a patch to rename exprno, rfno, etc
>> to all be called dno to make this connection more obvious.

> Attached.  Passed regressions and basic testing.

Looks good, applied.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Emmanuel Cecchet
Date:
Subject: Re: Transactions and temp tables
Next
From: Guillaume Lelarge
Date:
Subject: Re: Patch for ALTER DATABASE WITH TABLESPACE