Postgres Pro
Downloads
Home   >   mailing lists

pgSet MoveNext bug ? - Mailing list pgadmin-hackers

From Robins Tharakan
Subject pgSet MoveNext bug ?
Date
Msg-id 36af4bed0803031724s681693e2pf392db9dfac4b5b4@mail.gmail.com
Whole thread Raw
Responses Re: pgSet MoveNext bug ?
List pgadmin-hackers
Tree view
Hi,

While reading the code, the PGSet->MoveNext() definition seems to have a small bug.

Since the PGSet->EOF() is defined as
bool Eof() const { return (!nRows || pos > nRows); }

I think it doesn't make sense to define PGSet->MoveNext() as
void MoveNext() { if (pos <= nRows) pos++; }

It should rather be
void MoveNext() { if (pos < nRows) pos++; }

The attached patch does the same.

Regards,
Robins Tharakan
Attachment

pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by dpage: r7111 - trunk/pgadmin3/plugins
Next
From: "Dave Page"
Date:
Subject: Re: Display line numbers in SQL view