Re: [HACKERS] Re: datetime regress test busted by incomplete checkin - Mailing list pgsql-hackers

From Thomas G. Lockhart
Subject Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Date
Msg-id 36AC93E0.C48F681@alumni.caltech.edu
Whole thread Raw
In response to Re: [HACKERS] Re: datetime regress test busted by incomplete checkin  (Oleg Broytmann <phd@sun.med.ru>)
Responses Re: [HACKERS] Re: datetime regress test busted by incomplete checkin  (Oleg Broytmann <phd@sun.med.ru>)
List pgsql-hackers
> Probably that's me. The patch attached. Is there any problem?

Could you phrase the query in the same style as most of the other tests
(a style we inherited from the original sources), where the first column
is a select of an empty string with the table count as the label? I
would suggest something like:

SELECT '' AS one, datetime('1994-01-01', '11:00') AS "Sat Jan 01 11:00:00 1994 PST";

I think we can use the actual current result in the result label (and
without underscores), since you are surrounding it with double quotes
anyway.

TIA
                     - Tom

> + QUERY: SET DateStyle = 'Postgres,noneuropean';
> + QUERY: SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> + Jan_01_1994_11am
> + ----------------------------
> + Sat Jan 01 11:00:00 1994 PST
> + (1 row)


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Another source of snprintf/vsnprintf code
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Re: datetime regress test busted by incomplete checkin