Re: [HACKERS] Syntax errors in current tree - Mailing list pgsql-hackers

From Vadim Mikheev
Subject Re: [HACKERS] Syntax errors in current tree
Date
Msg-id 36A2C977.72A76070@krs.ru
Whole thread Raw
In response to Syntax errors in current tree  ("D'Arcy" "J.M." Cain <darcy@druid.net>)
Responses Re: [HACKERS] Syntax errors in current tree  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
"D'Arcy J.M. Cain" wrote:
> 
>  really hesitate to make this criticism given all the work people are
> doing on the system and all the great features and fixes that are
> being added but could we please make it a hard and fast rule that
> nothing gets added into the tree until the person adding it has at
> least compiled the source, if not a full regression test.  I have ^^^^^^^^^^^^^^^^^^^^^^^^^
This is what I always do!
forUpdate was added by me into gram.y and parsenodes.h:SelectStmt.
I guess that I committed both backend & include dirs
(cvs update inside include dir doesn't show anything for
parsenodes.h)...

> finally jumped in and tried to add full primary key support but I
> keep stumbling over simple syntax errors in files I am not working
> on but that keep me from fully testing my own changes.  Here's what
> I get compiling gram.y[c].
> 
> gcc -I../../include -I../../backend   -I/usr/local/include -O2 -pipe  -Wall -Wmissing-prototypes -I.. -Wno-error   -c
gram.c-o gram.o
 
> /usr/local/share/bison.simple: In function `yyparse':
> /usr/local/share/bison.simple:327: warning: implicit declaration of function `yyerror'
> /usr/local/share/bison.simple:387: warning: implicit declaration of function `yylex'
> gram.y:2797: `forUpdate' undeclared (first use in this function)

Vadim


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Postgres Speed or lack thereof
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Syntax errors in current tree