Re: [HACKERS] Fix performance of generic atomics - Mailing list pgsql-hackers

From Jesper Pedersen
Subject Re: [HACKERS] Fix performance of generic atomics
Date
Msg-id 36029be0-e886-34fe-1c81-8d18be4a5fbe@redhat.com
Whole thread Raw
In response to Re: [HACKERS] Fix performance of generic atomics  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Fix performance of generic atomics
Re: [HACKERS] Fix performance of generic atomics
List pgsql-hackers
On 09/05/2017 02:24 PM, Tom Lane wrote:
> Jesper Pedersen <jesper.pedersen@redhat.com> writes:
>> I have tested this patch on a 2-socket machine, but don't see any
>> performance change in the various runs. However, there is no regression
>> either in all cases.
> 
> Hm, so if we can't demonstrate a performance win, it's hard to justify
> risking touching this code.  What test case(s) did you use?
> 

I ran pgbench (-M prepared) with synchronous_commit 'on' and 'off' using 
both logged and unlogged tables. Also ran an internal benchmark which 
didn't show anything either.

Setting the entry back to "Needs Review" for additional feedback from 
others.

Best regards, Jesper



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Fix performance of generic atomics
Next
From: Greg Stark
Date:
Subject: Re: [HACKERS] JIT compiling expressions/deform + inlining prototype v2.0