Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup asparallel-restricted. - Mailing list pgsql-committers

From David Steele
Subject Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup asparallel-restricted.
Date
Msg-id 3542dfbd-68dd-f246-8fb5-d2ac25d947fc@pgmasters.net
Whole thread Raw
In response to [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.  (Robert Haas <rhaas@postgresql.org>)
Responses Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.
List pgsql-committers
On 3/6/17 12:48 PM, Robert Haas wrote:
> Mark pg_start_backup and pg_stop_backup as parallel-restricted.
>
> They depend on backend-private state that will not be synchronized by
> the parallel machinery, so they should not be marked parallel-safe.
> This issue also exists in 9.6, but we obviously can't do anything
> about 9.6 clusters that already exist.  Possibly this could be
> back-patched so that future 9.6 clusters would come out OK, or
> possibly we should back-patch some other fix, but that would need more
> discussion.

I think it would be worth back-patching the catalog fix for future 9.6
clusters as a start.  Parallelism is off by default in 9.6 so that
mitigates some of the problem.

I don't have any regression tests that cover backups when parallelism is
enabled in 9.6, but I'm willing to do that and see if this is a
realistic issue or not.

--
-David
david@pgmasters.net


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Notify bgworker registrant after freeing worker slot.
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup as parallel-restricted.