Re: [COMMITTERS] pgsql: Notify bgworker registrant after freeing worker slot. - Mailing list pgsql-committers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Notify bgworker registrant after freeing worker slot.
Date
Msg-id 21855.1488825876@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Notify bgworker registrant after freeingworker slot.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Mar 6, 2017 at 8:21 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> On Fri, Mar 3, 2017 at 9:27 AM, Robert Haas <rhaas@postgresql.org> wrote:
>>> Notify bgworker registrant after freeing worker slot.

>> After this commit, I am seeing parallel queires being stucked on my
>> windows machine.  I think the notify pid is stale in
>> ReportBackgroundWorkerExit() as we are freeing the same in
>> ForgetBackgroundWorker().  Attached patch fixes the problem for me.
>> Ashutosh Sharma has independently reported (offlist) this problem to me.

> Thanks for the report and patch.  Committed.

Hmm, maybe this also explains skink's recent failure in the
select_parallel test.  I was going to go try to duplicate that, but
now maybe I'll just wait to see if its next run is green.

            regards, tom lane


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Combine several DROP variants into generic DropStmt
Next
From: David Steele
Date:
Subject: Re: [COMMITTERS] pgsql: Mark pg_start_backup and pg_stop_backup asparallel-restricted.